Skip to content

Conversation

@winder
Copy link
Collaborator

@winder winder commented Jan 23, 2026

Automation to ensure go mods, mocks and openapi generated files are all up to date.

@winder winder force-pushed the will/indexer-api-docs branch from a2f75b2 to 1f194a9 Compare January 24, 2026 14:32
@github-actions
Copy link

Code coverage report:

Package main will/indexer-api-docs diff
github.com/smartcontractkit/chainlink-ccv/aggregator 48.36% 48.36% +0.00%
github.com/smartcontractkit/chainlink-ccv/cmd 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/committee 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/common 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/executor 41.79% 41.85% +0.06%
github.com/smartcontractkit/chainlink-ccv/indexer 36.99% 37.02% +0.03%
github.com/smartcontractkit/chainlink-ccv/integration 46.51% 46.51% +0.00%
github.com/smartcontractkit/chainlink-ccv/pkg 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/pricer 39.76% 39.76% +0.00%
github.com/smartcontractkit/chainlink-ccv/protocol 54.58% 54.58% +0.00%
github.com/smartcontractkit/chainlink-ccv/verifier 60.45% 60.46% +0.01%

with:
cache: true
go-version: ${{ steps.tool_versions.outputs.go_version }}
go-version-file: 'go.mod'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc cleanup in yaml files

arch=$(uname -m)

install_dir=/usr/local
$install_dir/bin/protoc --version | grep $VERSION
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc shellcheck fixes

docker run --rm \
-v "${PWD}:/local" \
openapitools/openapi-generator-cli generate \
openapitools/openapi-generator-cli:v7.19.0 generate \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin version so that the VERSION file doesn't change unexpectedly.

run: just install-go-tools

- name: Run repo hygiene checks
run: tools/bin/check_repo_clean.sh tidy mock generate shellcheck
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New CI command. Runs the provided just targets and ensures they don't modify the repo or return an error.

@winder winder marked this pull request as ready for review January 26, 2026 14:04
@winder winder requested review from a team and skudasov as code owners January 26, 2026 14:04
Comment on lines -40 to -41
with:
just-version: '1.40.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern w/ this unpinning is if there's a new major version that somehow breaks things - is that a realistic concern?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thought but removed it anyway because: we don't pin the version for developers, we don't pin it consistently in other actions, and the just project would be foolish to break things in that way.

@winder winder added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 4df1c73 Jan 26, 2026
19 of 20 checks passed
@winder winder deleted the will/indexer-api-docs branch January 26, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants